-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework onsite admin interface #337
base: production
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last step to make this deployable, we need to rebuild the base docker image to include the new python dependency. You'll need to have a Github CR PAT with write:packages
scope, then set GITHUB_USER
and GITHUB_CR_PAT
environment variables (e.g. in .envrc
).
make docker-login
make build-base-docker-image
It should modify the Dockerfile to point to the new base image, push and commit that.
Looks beautiful. There's a few problems this is running into on staging around content security policies, see this glitchtip, I think we have those set relatively strictly for staging/production, though I'm surprised this hasn't come up before since the old interface also ends up using an MQTT websocket connection. Also seeing this in the console for the MQTT library: Do you know what we might be missing here? |
This is a complete reimplementation of the frontend of the onsite admin UI. It makes the page more interactive and responsive, while also making it easier to add future features. All of the original (working) functionality and keyboard shortcuts have been reimplemented, in addition to many new features.
It introduces esbuild for compiling and bundling TypeScript and SASS, which might also be useful for future user-facing UI enhancements.
As part of these frontend enhancements, a number of other changes were introduced. These include:
PRINT_VIA_MQTT
which publishes to the MQTT action topic for the terminal allowing software running on the local machine to process the print request without having to interact with a system print dialog. This is compatible with reg-interface.This is a pretty substantial change, and I understand if not everything here is desired.
(Moved from forked branch in #335)