chore: Upgrade Go version to 1.23 (#136)

furiko-io · Sep 13, 2024 · d115ffe · d115ffe
1 parent 4a40039
commit d115ffe
Show file tree

Hide file tree

Showing 54 changed files with 533 additions and 219 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -7,6 +7,11 @@ linters-settings:
     disabled-checks:
       - singleCaseSwitch
       - ifElseChain
+  gosec:
+    excludes:
+      # G115: Potential integer overflow when converting between integer types
+      # Excluded due to false positives.
+      - G115
 
 issues:
   exclude-rules:
@@ -32,9 +37,9 @@ linters:
   enable:
     - asciicheck
     - bodyclose
+    - copyloopvar
     - dupl
     - errcheck
-    - exportloopref
     - gocognit
     - goconst
     - gocritic

diff --git a/Makefile b/Makefile
@@ -76,7 +76,7 @@ help: ## Display this help.
 ##@ Development
 
 .PHONY: generate
-generate: generate-deepcopy generate-groups ## Generate Go code.
+generate: generate-deepcopy generate-groups fmt ## Generate Go code.
 
 generate-deepcopy: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
 	$(CONTROLLER_GEN) object:headerFile="$(LICENSE_HEADER_GO)" paths="./..."
@@ -219,10 +219,10 @@ $(LOCALBIN): ## Ensure that the directory exists
 
 ## Tool Versions
 KUSTOMIZE_VERSION ?= v4.5.5
-CONTROLLER_TOOLS_VERSION ?= v0.8.0
+CONTROLLER_TOOLS_VERSION ?= v0.14.0
 YQ_VERSION ?= v4.14.1
 GOIMPORTS_REVISER_VERSION ?= 32c80678d5d73a50b6966f06b346de58b1d018f1
-GOLANGCI_LINT_VERSION ?= v1.55.2
+GOLANGCI_LINT_VERSION ?= v1.61.0
 LICENSEHEADERCHECKER_VERSION ?= v1.3.0
 GORELEASER_VERSION ?= v1.8.2
 

diff --git a/apis/config/v1alpha1/zz_generated.deepcopy.go b/apis/config/v1alpha1/zz_generated.deepcopy.go
diff --git a/apis/execution/v1alpha1/zz_generated.deepcopy.go b/apis/execution/v1alpha1/zz_generated.deepcopy.go
diff --git a/config/common/rbac/execution/controller/cluster_role.yaml b/config/common/rbac/execution/controller/cluster_role.yaml
@@ -2,7 +2,6 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  creationTimestamp: null
   name: controller-role
 rules:
 - apiGroups:

diff --git a/config/common/rbac/execution/webhook/cluster_role.yaml b/config/common/rbac/execution/webhook/cluster_role.yaml
@@ -2,7 +2,6 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  creationTimestamp: null
   name: webhook-role
 rules:
 - apiGroups:

diff --git a/config/common/webhook/execution/manifests.yaml b/config/common/webhook/execution/manifests.yaml
@@ -2,7 +2,6 @@
 apiVersion: admissionregistration.k8s.io/v1
 kind: MutatingWebhookConfiguration
 metadata:
-  creationTimestamp: null
   name: mutating-webhook-configuration
 webhooks:
 - admissionReviewVersions:
@@ -11,9 +10,9 @@ webhooks:
     service:
       name: webhook-service
       namespace: system
-      path: /mutating/jobs.execution.furiko.io
+      path: /mutating/jobconfigs.execution.furiko.io
   failurePolicy: Fail
-  name: mutating.webhook.jobs.execution.furiko.io
+  name: mutating.webhook.jobconfigs.execution.furiko.io
   rules:
   - apiGroups:
     - execution.furiko.io
@@ -23,17 +22,17 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - jobs
+    - jobconfigs
   sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
     service:
       name: webhook-service
       namespace: system
-      path: /mutating/jobconfigs.execution.furiko.io
+      path: /mutating/jobs.execution.furiko.io
   failurePolicy: Fail
-  name: mutating.webhook.jobconfigs.execution.furiko.io
+  name: mutating.webhook.jobs.execution.furiko.io
   rules:
   - apiGroups:
     - execution.furiko.io
@@ -43,13 +42,12 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - jobconfigs
+    - jobs
   sideEffects: None
 ---
 apiVersion: admissionregistration.k8s.io/v1
 kind: ValidatingWebhookConfiguration
 metadata:
-  creationTimestamp: null
   name: validating-webhook-configuration
 webhooks:
 - admissionReviewVersions:
@@ -58,9 +56,9 @@ webhooks:
     service:
       name: webhook-service
       namespace: system
-      path: /validating/jobs.execution.furiko.io
+      path: /validating/jobconfigs.execution.furiko.io
   failurePolicy: Fail
-  name: validation.webhook.jobs.execution.furiko.io
+  name: validation.webhook.jobconfigs.execution.furiko.io
   rules:
   - apiGroups:
     - execution.furiko.io
@@ -70,17 +68,17 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - jobs
+    - jobconfigs
   sideEffects: None
 - admissionReviewVersions:
   - v1
   clientConfig:
     service:
       name: webhook-service
       namespace: system
-      path: /validating/jobconfigs.execution.furiko.io
+      path: /validating/jobs.execution.furiko.io
   failurePolicy: Fail
-  name: validation.webhook.jobconfigs.execution.furiko.io
+  name: validation.webhook.jobs.execution.furiko.io
   rules:
   - apiGroups:
     - execution.furiko.io
@@ -90,5 +88,5 @@ webhooks:
     - CREATE
     - UPDATE
     resources:
-    - jobconfigs
+    - jobs
   sideEffects: None