Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio update #321

Merged
merged 22 commits into from
Nov 12, 2024
Merged

Portfolio update #321

merged 22 commits into from
Nov 12, 2024

Conversation

leventeBajczi
Copy link
Contributor

@leventeBajczi leventeBajczi commented Nov 11, 2024

Changes:

  • portfolios have been created for this year (horn25, bounded25, complex25)
  • in complex25, when we encounter a multithreaded program (unreach-call), we start with a quick OC check
  • loopunrollpass's flag has been converted into an xcfa flag (unsafeUnroll)
  • OC check should be parameterized well (@csanadtelbisz)
  • bounded25 should be updated (will be done by merging EmergenTheta Update #314)

@leventeBajczi leventeBajczi added the Ready to test This will run the final sonar check in PRs. label Nov 11, 2024
Copy link
Contributor

@csanadtelbisz csanadtelbisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In portfolio files, I suggest considering imports for config enum values to improve readability (so that we could use CONFIG_OPTION instead of LongEnumClassName.CONFIG_OPTION).

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.5% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

Copy link

Benchexec test report for a selection of SV-Benchmarks (correct / incorrect / all):

Rundefinition BOUNDED CEGAR HORN
SV-COMP25_no-data-race ❓ (0 / 0 / 404) HTML/CSV ✅ (51 / 0 / 107) HTML/CSV ❓ (0 / 0 / 415) HTML/CSV
SV-COMP25_no-overflow ❓ (0 / 0 / 17) HTML/CSV ❓ (0 / 0 / 17) HTML/CSV ❓ (0 / 0 / 17) HTML/CSV
SV-COMP25_termination ✅ (4 / 0 / 26) HTML/CSV ✅ (12 / 0 / 30) HTML/CSV ✅ (13 / 0 / 40) HTML/CSV
SV-COMP25_unreach-call ✅ (5 / 0 / 180) HTML/CSV ✅ (15 / 0 / 88) HTML/CSV ❗ (15 / 1 / 184) HTML/CSV
SV-COMP25_valid-memcleanup ❓ (0 / 0 / 65) HTML/CSV ❓ (0 / 0 / 65) HTML/CSV ❓ (0 / 0 / 65) HTML/CSV
SV-COMP25_valid-memsafety ❓ (0 / 0 / 443) HTML/CSV ❗ (35 / 3 / 334) HTML/CSV ❗ (5 / 2 / 417) HTML/CSV

@leventeBajczi leventeBajczi merged commit 35fd050 into master Nov 12, 2024
83 of 86 checks passed
@leventeBajczi leventeBajczi deleted the portfolio-update branch November 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to test This will run the final sonar check in PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants