Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumtype smtlib #272

Merged
merged 8 commits into from
Jul 9, 2024
Merged

Enumtype smtlib #272

merged 8 commits into from
Jul 9, 2024

Conversation

RipplB
Copy link
Contributor

@RipplB RipplB commented Jun 26, 2024

Copy link
Contributor

@mondokm mondokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a very rough first review

@RipplB RipplB force-pushed the enumtype_smtlib branch from 4703cb0 to 98e29d3 Compare June 28, 2024 15:12
RipplB added 3 commits June 29, 2024 20:17
Now the test uses solvermanagers and a constant string can be set to
easily define which solver to run the tests with. If it is set to an
SMTLib solver, a helper BeforeClass method checks if specified version
is installed, and if not, installs it.
@RipplB RipplB force-pushed the enumtype_smtlib branch from 98e29d3 to fdb14f9 Compare June 29, 2024 18:17
@mondokm
Copy link
Contributor

mondokm commented Jul 3, 2024

Tests fail for theta-solver-smtlib.
Formatting is wrong on subprojects/common/core/src/main/java/hu/bme/mit/theta/core/utils/ExprSimplifier.java

@RipplB RipplB mentioned this pull request Jul 5, 2024
@RipplB RipplB force-pushed the enumtype_smtlib branch from fdb14f9 to 5f2b8bb Compare July 5, 2024 13:28
The generic smtlib solver binary checks process health after starting
it. If the process didn't fail fast enough, this check reported a
running status, but later calls failed. Now introduced a 50ms thread
sleep after starting the process, to make sure it catches all startup
fails.
@RipplB RipplB force-pushed the enumtype_smtlib branch from 5f2b8bb to 021194d Compare July 6, 2024 14:04
RipplB and others added 3 commits July 6, 2024 16:54
NaN floating point values should not be equal to any other value. This
behavior is correctly implemented in the FpLitExpr #eq and #neq methods.
To utilize that, manual comparison in simplification is now swapped to
call these methods, resulting in correct behaviour: (= (NaN) (NaN)) for
example now simplifies to false.
@RipplB RipplB force-pushed the enumtype_smtlib branch from 021194d to 285b991 Compare July 6, 2024 14:54
@mondokm mondokm added the Ready to test This will run the final sonar check in PRs. label Jul 9, 2024
Copy link

sonarqubecloud bot commented Jul 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
35.0% Coverage on New Code (required ≥ 60%)
6.5% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

@mondokm mondokm merged commit 05f4293 into ftsrg:master Jul 9, 2024
42 of 43 checks passed
@RipplB RipplB deleted the enumtype_smtlib branch July 12, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to test This will run the final sonar check in PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name collision checks for XSTS, enum type rework
2 participants