Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for + modes to SSHFile #51

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

mxmlnkn
Copy link
Contributor

@mxmlnkn mxmlnkn commented Oct 3, 2024

I don't see a reason to forbid these modes. They work out of the box. Were there any reasons for adding the mode check and TODO comment in the first place?

@@ -18,8 +18,7 @@ def __init__(
self.fs = fs
self.loop = fs.loop

# TODO: support r+ / w+ / a+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isidentical @efiop - if you remember anything about this - it would be helpful

@shcheklein shcheklein merged commit 34b52b2 into fsspec:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants