SSHFileSystem._info should strip the protocol from the path #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on some pain points i was having and looking at other FS impls.
ryaminal
changed the title
could you please give more details?
could you please share some links? thanks! |
|
@shcheklein, here are some answers to your questions. Pain pointsThe pain points with Examples from other FS impls that strip in
|
shcheklein
approved these changes
Apr 21, 2024
|
Thanks @ryaminal for the context. @martindurant @efiop please merge it and release when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on some pain points i was having while using GenericFileSystem.
Looks like other FS implementations also strip first. Seems like a "safe" thing to do.
pytestpasses... for what it's worth.