Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing kwargs to sftp client #41

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ttomasz
Copy link

@ttomasz ttomasz commented Feb 17, 2024

Fixes #39

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.07%. Comparing base (64cc6ef) to head (59a8fe7).
Report is 1 commits behind head on main.

Current head 59a8fe7 differs from pull request most recent head b971999

Please upload reports for the commit b971999 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   94.19%   94.07%   -0.13%     
==========================================
  Files          13       13              
  Lines         723      742      +19     
==========================================
+ Hits          681      698      +17     
- Misses         42       44       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ttomasz
Copy link
Author

ttomasz commented Mar 11, 2024

@efiop Would you mind reviewing this PR?

sshfs/spec.py Outdated Show resolved Hide resolved
@efiop
Copy link
Member

efiop commented Mar 18, 2024

Hey, @ttomasz , thanks for the PR! Please see some suggestions above.

@shcheklein
Copy link
Collaborator

@ttomasz a gentle reminder :) or can we close this PR?

@ttomasz
Copy link
Author

ttomasz commented Jun 1, 2024

Sorry, was quite busy past few months 😅 I should be able to finish this up in June.

@ttomasz ttomasz force-pushed the feature/allow-passing-params-to-sftp-client branch from 2a39ec4 to 0a8a32d Compare June 16, 2024 16:57
@ttomasz
Copy link
Author

ttomasz commented Jun 16, 2024

Changed popping kwargs to separate parameter for stuff to pass to underlying library.

@ttomasz
Copy link
Author

ttomasz commented Jun 16, 2024

Sorry for the mess with the commits. Do you want me to revert client_args/connect_args to being kwargs instead of parameter? Or is the current state ok?

@shcheklein shcheklein requested a review from efiop June 16, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to pass path_encoding parameter?
4 participants