-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing kwargs to sftp client #41
base: main
Are you sure you want to change the base?
allow passing kwargs to sftp client #41
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 94.19% 94.07% -0.13%
==========================================
Files 13 13
Lines 723 742 +19
==========================================
+ Hits 681 698 +17
- Misses 42 44 +2 ☔ View full report in Codecov by Sentry. |
@efiop Would you mind reviewing this PR? |
Hey, @ttomasz , thanks for the PR! Please see some suggestions above. |
@ttomasz a gentle reminder :) or can we close this PR? |
Sorry, was quite busy past few months 😅 I should be able to finish this up in June. |
2a39ec4
to
0a8a32d
Compare
Changed popping kwargs to separate parameter for stuff to pass to underlying library. |
Sorry for the mess with the commits. Do you want me to revert client_args/connect_args to being kwargs instead of parameter? Or is the current state ok? |
Fixes #39