Handle cache_timeout = 0 in GCSFileSystem #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyewang
force-pushed
the
amyewang/issue-645
branch
from
113a4f5 to
ac8a8cc
Compare
|
A test for this would be nice. |
|
@martindurant added a test to |
| @@ -1428,6 +1428,8 @@ def test_expiry_keyword(): | |||
| assert gcs.dircache.listings_expiry_time == 1 | |||
| gcs = GCSFileSystem(cache_timeout=1, token="anon") | |||
| assert gcs.dircache.listings_expiry_time == 1 | |||
| gcs = GCSFileSystem(cache_timeout=0, token="anon") | |||
| assert gcs.dircache.listings_expiry_time == 0 | |||
There was a problem hiding this comment.
Does this imply that the cache is disabled? What was the previous value before this PR, None?
There was a problem hiding this comment.
Yes, based on the docstring the listings_expiry_time should be set to 0, which means cache has a timeout of 0. Before this change the gcs.dircache.listings_expiry_time evaluated to None, so the cache was enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645