Fix md5 hash logic. Make it order agnostic. #640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of headers is not consistent in API calls. Sometimes, md5 comes first, and sometimes crc32.
The current code works fine when md5 comes first and fails when crc comes first.
Failure example:
In the above example, crc comes first and md5 comes later. The header
x-goog-hash
has the valuecrc32c=KXvQqg==, md5=mZFLkyvTelC5g8XnyQrpOw==
.Please take a look at the space after the comma. This extra space was failing the code for md5. This extra space is there because of how requests lib handles duplicate headers.