Add exception handling for SMBFileSystem init connection errors #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsspec/implementations/smb.py
Outdated
| retried_errors.append(exc) | ||
|
|
||
| if retry < self.register_session_retries - 1: | ||
| time.sleep(1) |
There was a problem hiding this comment.
May as well make the retry time configurable and ideally exponential, base * factor**retry
There was a problem hiding this comment.
That is great idea. Should the exponential option be also configurable? To avoid confusing a user?
There was a problem hiding this comment.
I would suggest to make the max time equal to the wait time
There was a problem hiding this comment.
That's an interesting idea, but not the way around it is is other implementations (example). At least, then I would call it "max_wait_time", but probably better to have "base_wait_time" and backoff factor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1571
This PR implements exception handling for
SMBFileSystem._connect()which brings changes to the current implementation:Retrying all other exceptions could be dropped in the future once all exceptions suited for retry are identified. Until then, we should probably not affect current behavior as much as we should.
Other feature proposed in this PR is raising latest exception after all retries are exhausted. This will at least inform a user about excepted issue. (related question is whether to implement ExceptionGroup to inform about all exceptions)
Additionally, an implementation for exponential wait time growth from 0 to requested time (included) is added.
The wait time is calculated using exponential function. For factor=1 all wait times will be equal to
register_session_retry_wait. For any number of retries, the last wait time will be equal toregister_session_retry_waitand for retries>1 the first wait time will be equal toregister_session_retry_wait / factor.By default a factor is made 10 as most optimal (quick first attempts)