Fix nested subdirectory listing #1430 #1433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walking up the directory tree never went higher than one directory up:
For example
A/B/C
, would registerA/B/C -> A/B
, but notA/B -> A
, due to this linefilesystem_spec/fsspec/implementations/reference.py
Lines 994 to 996 in 1637a97
The solution is to first collect all the newly observed sub-directories, and only then update
dircache
with new directory entries.ReferenceFileSystem
#1430