Fix open_local returning list for pathlib.Path #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindurant
reviewed
Nov 9, 2023
fsspec/core.py
Outdated
| def open_local(url, mode="rb", **storage_options): | ||
| def open_local( | ||
| url: str | list[str] | Path | list[Path], | ||
| mode: Optional[Literal["rb"]] = "rb", |
There was a problem hiding this comment.
This annotation is wrong, I think, it implies mode can be ["rb", None] and nothing else.
Suggested change
| mode: Optional[Literal["rb"]] = "rb", | |
| mode: str = "rb", |
The actual legal possibilities depend on the target filesystem, but include ["rb", "r", "rt", "w", "wb", "wt"]
|
I think you may need to get those type things to import. Or just remove them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input of single
pathlib.Pathto url argument now returns string instead of list similar to input of single str.