fix the incorrect list of ends for _cat_ranges #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(also in |
|
Whilst you are right, the inputs are expected to be lists. This functions should have a docstring saying so, and tests making sure that it works. Obviously, this has been somewhat an experimental method, but it should be graduated to full use. |
AlbertXingZhang
force-pushed
the
_cat_ranges_ends
branch
from
019f553 to
7be37a1
Compare
|
Hi @martindurant, thanks for pointing out another place I missed. I also added it to the changes and wrote some docstrings for them. Please let me know if I need to make more changes or feel free to help revise them. Thanks. |
|
Hi @martindurant, thanks for reviewing. I also trimmed the trailing whitespace complained by lint. I'm sorry I didn't notice it before. |
|
Thank you @AlbertXingZhang |
|
Thanks for merging, @martindurant🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the list of "ends" should come from the argument "ends" if it is not iterable for the function "_cat_ranges".