Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMB: Remove unexpected kwargs (coming from UPath.rename) #1391

Merged
merged 3 commits into from
Oct 19, 2023
Merged

SMB: Remove unexpected kwargs (coming from UPath.rename) #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d8cd01
SMB: Remove unexpected kwargs (coming from UPath.rename)
Oct 17, 2023
5294a2e
Use explicit args instead of manupilating kwargs
martin-schulze-e2m Oct 18, 2023
95013b8
Avoid import problems under Windows
Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fsspec/implementations/smb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ def _rm(self, path):
else:
smbclient.remove(wpath, port=self._port)

def mv(self, path1, path2, **kwargs):
def mv(self, path1, path2, recursive=None, maxdepth=None, **kwargs):
wpath1 = _as_unc_path(self.host, path1)
wpath2 = _as_unc_path(self.host, path2)
smbclient.rename(wpath1, wpath2, port=self._port, **kwargs)
Expand Down
6 changes: 6 additions & 0 deletions fsspec/implementations/tests/test_smb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,9 @@ def test_makedirs_exist_ok(smb_params):
fsmb = fsspec.get_filesystem_class("smb")(**smb_params)
fsmb.makedirs("/home/a/b/c")
fsmb.makedirs("/home/a/b/c", exist_ok=True)


def test_rename_from_upath(smb_params):
fsmb = fsspec.get_filesystem_class("smb")(**smb_params)
fsmb.makedirs("/home/a/b/c", exist_ok=True)
fsmb.mv("/home/a/b/c", "/home/a/b/d", recursive=False, maxdepth=None)