Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Python 3, classes inherit object implicitly #1370

Merged
merged 1 commit into from
Sep 21, 2023
Merged

In Python 3, classes inherit object implicitly #1370

merged 1 commit into from
Sep 21, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

No need to inherit (object) explicitly.

@martindurant
Copy link
Member

In that case you don't need () either; but I thought it was still good form to declare object in these cases.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Sep 21, 2023 •
edited
Loading

All examples in the Python 3 documentation omit the object inheritance, see for example 9. Classes. Inconsistency with the Python docs doesn't help developers.

Also pyupgrade removes (object).

@DimitriPapadopoulos
In Python 3, classes inherit object implicitly
ae620f4 
No need to inherit (object) explicitly.
@martindurant martindurant merged commit b9095c0 into fsspec:master Sep 21, 2023
11 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the object branch September 21, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @martindurant