-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow blobs and file systems to pickle #479
Conversation
Awesome, thanks for tackling this. I installed from this branch and it seems to have fixed my issue, is there any reason this is still a draft? |
Thanks for trying it out! Just forgot to continue working on this, I will publish it for review shortly. |
Could we get a review from a maintainer? (Maybe @TomAugspurger @martindurant ?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the non-pickle code path is unchanged from before, and that pickling now also works, I'm OK with this change.
I have a couple of questions for consideration.
Thanks @ghidalgo3! I'll look into making a release with this shortly. |
I am also running into a similar issues as #477, trying to fix it by influencing the pickling behavior of blobs and file systems.