C#-friendly api #318
Merged
C#-friendly api #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use C#-style OptionalAttribute instead of F#-style optional arguments * Use Func and Action instead of F# functions
* Use C#-style OptionalAttribute instead of F#-style optional arguments
* Use Func instead of F# function
Tarmil
force-pushed
the
csharp-friendly-api
branch
from
ec2eee6
to
8908ffc
Compare
xperiandri
suggested changes
Aug 20, 2023
| this.MapFallback(fun ctx -> | ||
| let page = page ctx | ||
| let page = page.Invoke(ctx) |
There was a problem hiding this comment.
Suggested change
| let page = page.Invoke(ctx) | |
| let page = page.Invoke ctx |
There was a problem hiding this comment.
Thanks for the suggestions! I actually tend to prefer parenthesized syntax for methods though, even if they're single-argument.
| | None -> serOptions.Converters.Add(JsonFSharpConverter()) | ||
| | Some f -> f serOptions } | ||
| | null -> serOptions.Converters.Add(JsonFSharpConverter()) | ||
| | f -> f.Invoke(serOptions) } |
There was a problem hiding this comment.
Suggested change
| | f -> f.Invoke(serOptions) } | |
| | f -> f.Invoke serOptions } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313. (cc @xperiandri)
Use OptionalAttribute, Func and Action instead of F#-style optional parameters and functions to provide a more C#-friendly API.
This should be a source-compatible change for most users; however, it will break explicit uses of
?paramName = optionValue, and possibly some type inference scenarios for function arguments.