Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image after snap #861

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Update image after snap #861

merged 1 commit into from
Jan 13, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 13, 2024

Description:

This should address the long delay in updating images after a snap, allowing the removal of line 129 (which apparently isn't doing what I thought it should):
https://github.com/home-assistant/core/blob/45fec1d4048c72ef94df027154ecf7bf69c21c84/homeassistant/components/blink/camera.py#L128-L130
and reduce the number of update calls made to Blink.

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5d83708) 99.86% compared to head (4776917) 99.79%.
Report is 2 commits behind head on dev.

Files Patch % Lines
blinkpy/camera.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #861      +/-   ##
==========================================
- Coverage   99.86%   99.79%   -0.07%     
==========================================
  Files           8        8              
  Lines        1477     1481       +4     
==========================================
+ Hits         1475     1478       +3     
- Misses          2        3       +1     
Flag Coverage Δ
unittests 99.79% <80.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit 5146b36 into fronzbot:dev Jan 13, 2024
6 of 8 checks passed
@fronzbot
Copy link
Owner

Man I really gotta fix that coverage thing. Failing for missing 1 line in tests is annoying

@mkmer
Copy link
Contributor Author

mkmer commented Jan 13, 2024

I suppose we really should be adding tests for all new code. It's forces testing, and it's easy to be lazy :)
I'm thinking we do a release before the next core on January 31st and try to get the new stuff in the 2024.2 release of HA.
Lets shoot for January 24th for Blinkpy?

@mkmer mkmer deleted the Update-after-snap branch January 13, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants