-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new keys for wifi, lfr, and battery #835
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #835 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 8 8
Lines 1453 1458 +5
=======================================
+ Hits 1451 1456 +5
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think we need to go with a percentage and update HA to native unit of as a percentage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you just rip out the conversion to percentage (or make is a separate key if you really want it- either approach is fine with me) then we are good to merge.
remove extra battery_voltage assignment
If we want to change the
|
Description:
The API has changed - appears the wifi_strength and battery_voltage keys have been removed and a new key:
signals:{'lfr': 5, 'wifi': 4, 'battery': 3}
has been added.If the new key (signals) exists, we populate the values using the sub keys, if not, fall back to previous key names.
Add "sync_signal_strength" to attributes.
I'm not sure if the original wifi_strength key was 0-5 or actual signal strength (I think was was signal strength).I suppose we need to change the HA side to not show dBm? Should we do a percentage (5/5 = 100%, 1/5 - 20%) or maybe do this on the HA side?
Related issue (if applicable): fixes #
home-assistant/core#106509
Checklist:
tox
run successfully PR cannot be meged unless tests pass