Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #814

Closed
wants to merge 1 commit into from

Conversation

Rosi2143
Copy link
Contributor

add "pre-commit" to list of requirements

Description:

the package "pre-commit" was missing in the list of requirements

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • [no] Tests added to verify new code works

add "pre-commit" to list of requirements
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daea3cf) 99.65% compared to head (3e7ba5c) 99.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #814   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           8        8           
  Lines        1447     1447           
=======================================
  Hits         1442     1442           
  Misses          5        5           
Flag Coverage Δ
unittests 99.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot
Copy link
Owner

I appreciate the PR, but I'm not going to merge it for two reasons:

  1. Any test related tools go into requirements_test.txt, not requirements.txt
  2. I actually previously removed pre-commit requirement in this commit aa869cc#diff-8e46fa47648f051555a15d35f67ccace2ed6fcbb3404460adb964140d9f119a1

Ultimately I decided that I didn't want pre-commit to be a thing forced on contributors so don't want to maintain it as a requirement in the library

@fronzbot fronzbot closed this Nov 19, 2023
@Rosi2143 Rosi2143 deleted the Rosi2143-patch-requirements branch November 19, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants