Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python formatter #813

Merged
merged 1 commit into from
Nov 19, 2023
Merged

python formatter #813

merged 1 commit into from
Nov 19, 2023

Conversation

Rosi2143
Copy link
Contributor

fix some flake8 warnings and typos

Description:

  • fixed some flake8 warnings
  • fixed some typos
  • added some debug traces

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • [] Tests added to verify new code works

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (daea3cf) 99.65% compared to head (2d8219e) 99.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #813      +/-   ##
==========================================
+ Coverage   99.65%   99.86%   +0.20%     
==========================================
  Files           8        8              
  Lines        1447     1454       +7     
==========================================
+ Hits         1442     1452      +10     
+ Misses          5        2       -3     
Flag Coverage Δ
unittests 99.86% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix some flake8 warnings and typos
add new pytests to cover changed lines

Signed-off-by: Rosi2143 <[email protected]>
@fronzbot fronzbot merged commit 9fa0f86 into fronzbot:dev Nov 19, 2023
8 checks passed
@fronzbot
Copy link
Owner

Awesome, thanks for the contribution 👍

@Rosi2143 Rosi2143 deleted the formating_changes branch November 19, 2023 17:01
@Rosi2143
Copy link
Contributor Author

Awesome, thanks for the contribution 👍

Welcome.

I like the project. It helps me a lot, especially where the openHAB Boeing is currently not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants