-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blinkapp session call #782
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #782 +/- ##
==========================================
+ Coverage 99.64% 99.65% +0.01%
==========================================
Files 8 8
Lines 1404 1445 +41
==========================================
+ Hits 1399 1440 +41
Misses 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was accidentally committed to the repo
network_id = json_data.get("network_id") | ||
command_id = json_data.get("id") | ||
if command_id and network_id: | ||
while True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My aversion to while True
loops remains. Since we're doing a sleep
command here, can we change this to:
for i in range(0, SOME_MAX_TIMEOUT):
since in this case we know the SOME_MAX_TIMEOUT
variable would map to a certain number of polls/certain amount of time.
See #772 I think my comments apply there, not here. I believe that one is supposed to be merged first and just fell off my radar, my bad. |
I messed up, this was only supposed to have the |
Description:
Fix the auth call to use existing session
Related issue (if applicable): fixes #759
Checklist:
tox
run successfully PR cannot be meged unless tests pass