Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If a single sync module has a mix of camera type attached (any combo of normal, doorbell, mini), the
type
property would retain the previous state. Some tests were added to check for this as well as a small code modification. It may not fix any problems, but should be the routine more robust anyhow.Related issue (if applicable): Possibly impacts #580 , TBD
Checklist:
tox
run successfully PR cannot be meged unless tests pass