Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformatted stream url for blink mini #395

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Conversation

fronzbot
Copy link
Owner

Description:

Error pointed out by @cee-dee in #343

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #395 into dev will increase coverage by 1.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #395      +/-   ##
==========================================
+ Coverage   83.17%   84.32%   +1.14%     
==========================================
  Files           8        8              
  Lines         957      957              
==========================================
+ Hits          796      807      +11     
+ Misses        161      150      -11     
Flag Coverage Δ
#unittests 84.32% <100.00%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blinkpy/camera.py 86.16% <100.00%> (+5.66%) ⬆️
blinkpy/helpers/constants.py 100.00% <100.00%> (ø)
blinkpy/api.py 63.44% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8898436...f09a66c. Read the comment docs.

@fronzbot fronzbot merged commit 0842739 into dev Oct 25, 2020
@fronzbot fronzbot added this to the 0.16.4 milestone Oct 25, 2020
@fronzbot fronzbot deleted the fix-stream-format branch October 25, 2020 14:09
@fronzbot fronzbot mentioned this pull request Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant