Resolves #114 dates are validated for short months and leap years #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What it says on the tin. Resolves #114. What was happening was that
moment.js
actually catches and throws errors on such things just fine, just thatd3-time-format
changes the supplied date to the next closest valid one, creating the error as described.I changed it so that
default
uses amoment.js
format string to parse the date, rather than using thetimeParse
ofd3-time-format
.fmt
remains the same. I also chucked in a couple of tests for short months and leap dates.Please preserve this line to notify @roll (lead of this repository)