Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dps scoring bug fixes #692

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from
Draft

fix: dps scoring bug fixes #692

wants to merge 2 commits into from

Conversation

fribbels
Copy link
Owner

@fribbels fribbels commented Nov 7, 2024 •
edited
Loading

Pull Request

Description

  • Fixing some bugs with DPS score - batching them together to minimize the frequency of score changes
    • [Nerf] The assumption that the 200% sim can reuse the same feet as 100% is incorrect, we do need to permute the feet options for 200% to get an accurate perfect build for atk/spd boots

TODO:

  • Add diminishing returns on spd stacking for 100%?
  • Bug: Beta crash on high spd
  • Bug: Kafka not choosing spd boots

Related Issue

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

@fribbels fribbels marked this pull request as draft November 26, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fribbels