Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale bar for map view #112

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Scale bar for map view #112

wants to merge 2 commits into from
+113 −0

Conversation

skazemi
Copy link
Contributor

@skazemi skazemi commented Dec 27, 2022

No description provided.

@frewsxcv
Copy link
Owner

@skazemi Is this ready for review? Or are you still working on it?

@skazemi
Copy link
Contributor Author

skazemi commented Jan 2, 2023

@skazemi Is this ready for review? Or are you still working on it?

Yes, is there anything that can be improved?

@skazemi skazemi marked this pull request as ready for review January 2, 2023 11:15
@skazemi skazemi marked this pull request as draft January 2, 2023 11:41
@skazemi
Copy link
Contributor Author

skazemi commented Jan 2, 2023

The scale calculation is CRS dependent. I'll fix it in a new commit.

@frewsxcv
Copy link
Owner

frewsxcv commented Jan 2, 2023

The scale calculation is CRS dependent. I'll fix it in a new commit.

Sounds great! Just update the PR to be "Ready for review" when it's ready. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skazemi @frewsxcv