-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: vpn: Add documentation for evaluation of vpn protocols #3267
Conversation
1bba033
to
a3891b4
Compare
my first thought was, that your text and commit message talk about "mesh protocol" while the content isn't about mesh protocols but about VPNs ;-) |
@maurerle oh, had totally forgotten about this table already. I like the idea of adding it to the docs, thanks for the conversion effort! I think "fastd, null@l2tp, offloaded" should have "Single interface for all peers" -> "no" though? I'm also wondering if it could be nice to add a link to the Mesh VPN MTU page onto the "MTU overhead" heading? Also would be nice if someone could do a quick check for the l2tp kernel module if it supports multi-threading, on some live device or x86 VM. |
I'm also wondering what to do with the Tunneldigger entry. As all of its mentions was removed from the docs otherwise. Maybe add a link to the according community package on Github onto "Tunneldigger" and add "inofficial" in brackets? (or even "deprecated"?) Edit: As no new maintainer of it has stepped up so far, maybe "deprecated" might be more appropriate for now? |
And another thought, would it maybe make sense to place it higher instead of at the bottom as it's a nice, quick, first overview? (Edit: and then rename it to "Protocols Overview"?) |
"former supported" -> "formerly supported" (adverb) and add "ones" after "formerly supported"? Also no comma in this first sentence. (rule in English: if the sentence/clause can't exist on its own then no comma; I know, unintuitive for us native German speakers, where we use a lot more commas :D) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
@maurerle I can't see any changes. Did you forget to push the commits? |
a3891b4
to
aec45f8
Compare
Sorry, I pushed to the wrong repository (ffac).. Thanks |
aec45f8
to
0b0918d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a comma missing, otherwise LGTM.
0b0918d
to
ff03bb5
Compare
T-X created a pretty cool table to evaluate mesh-vpn protocols on this hedgedoc: https://md.chaotikum.org/zRkW6JXXQs-8WCnwdtig5w?view To give it more visibility, I would like to add it to the docs as suggested somewhere
ff03bb5
to
a54ed74
Compare
T-X created a pretty cool table to evaluate VPN uplink protocols used in gluon on this hedgedoc:
https://md.chaotikum.org/zRkW6JXXQs-8WCnwdtig5w?view
To give it more visibility, I would like to add it to the docs as suggested somewhere.
I hope this is fine for you @T-X and @rotanid ?