ffgraz-ddhcpd-batman-adv: fix shellcheck issues #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a bit of restructuring the flow as the A && B || C can run C if either A or B fails. This seemed unintentional.
grische
force-pushed
the
fix/shellcheck-ffgraz-ddhcpd-batman-adv
branch
from
ece0f2e
to
bf49b7b
Compare
|
We don't use batman in graz and this was mostly packaged because it already existed elsewhere (I think sargon's gluon package repo) So I can't test this but I also don't see any obvious problems with the changes |
|
@mkg20001 I am happy to merge this if you approve the PR |
mkg20001
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a bit of restructuring the flow as the A && B || C can run C if either A or B fails. This seemed unintentional.