-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
philmel: cleanup #893
Open
FFHener
wants to merge
2
commits into
main
Choose a base branch
from
philmel-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
philmel: cleanup #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFHener
force-pushed
the
philmel-cleanup
branch
2 times, most recently
from
July 26, 2024 11:06
b72b78e
to
18da6a9
Compare
noxilixon
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@Petrella are you up for making this PR ready so we can merge it? |
FFHener
force-pushed
the
philmel-cleanup
branch
2 times, most recently
from
October 21, 2024 17:05
5ed1d01
to
a62b57c
Compare
FFHener
force-pushed
the
philmel-cleanup
branch
2 times, most recently
from
November 13, 2024 19:19
c5d63fd
to
b86e7a2
Compare
FFHener
force-pushed
the
philmel-cleanup
branch
from
November 15, 2024 15:37
b86e7a2
to
acd8be1
Compare
noxilixon
requested changes
Nov 18, 2024
Switched IPs Switched mgmt-vlan to 438 Added nearfield devices Added frequency management Replaced some Devices
FFHener
force-pushed
the
philmel-cleanup
branch
2 times, most recently
from
November 21, 2024 08:46
77b2e41
to
a82fe78
Compare
FFHener
force-pushed
the
philmel-cleanup
branch
from
November 21, 2024 08:47
a82fe78
to
2ce7104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a meeting with @patrella and we definied together how the location will look like after the maintenance work.
Please review, but do not merge as it doenst reflect the current state. I will merge it after the on site work is done