-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APK #1073
base: main
Are you sure you want to change the base?
APK #1073
Conversation
I think commit version: fix snapshot imagebuilder url can be dropped. That should be covered by 08873f6 which was merged last week by yourself. |
Apart from the comment above, LGTM. Wow, it really seems future is now, never imagined that OpenWRT will have another package manager than opkg :) |
No, you didn't test that and broke it, this fixed your commit :) 🍻 |
Ups i tested that with a device i was strongly assuming to run on snapshot. Let me fix that.. |
I'm confused.. actually i wasnt inteding to fix snapshot, but 24.10. Can you rebase on that branch commits which contain the fix and a small change to the inline var templating on the feed_url, which now follows ansible common practice.. |
c50d41c
to
c9d3fcb
Compare
I picked the templating commit, didn't know the inline templates are evaluated lazily, very useful! The URL string construction is perhaps a little overengineered for my taste - a) we have the version group_var exactly for this, b) we need a snapshot-specific feed URL as well, and c) I don't want to spend mental capacity only to figure out a simple URL string. And finally there's only 2 (at most 3) possible values for that URL string anyway 🍻 :) |
APK on snapshot exposes all kinds of old dependency issues. Here it's that the iptables/iptables6 meta package has been deprecated for years. (Also need to fix the same in olsrd.) ERROR: unable to select packages: ip6tables (virtual): note: please select one of the 'provided by' packages explicitly provided by: ip6tables-nft ip6tables-zz-legacy required by: world[ip6tables] olsrd-2024.06.09~d72be9ad-r1[ip6tables] iptables (virtual): note: please select one of the 'provided by' packages explicitly provided by: iptables-nft iptables-zz-legacy required by: olsrd-2024.06.09~d72be9ad-r1[iptables]
The falter feed is now also set up within the image
|
Related: openwrt/routing#1085 & freifunk-berlin/ansible#139