Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make update-python3-requirements in the dev container (again) #7400

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Dec 20, 2024

Status

Ready for review

Description of Changes

Some packages, especially mod-wsgi, have dependencies on system packages and cannot universally be run on the host.

Moving it back into the container will be a bit slower, but overall it should still be noticibly faster than pre-uv.

Fixes #7245.

Testing

  • running make update-python3-requirements works

Deployment

Any special considerations for deployment? n/a

Some packages, especially mod-wsgi, have dependencies on system packages
and cannot universally be run on the host.

Moving it back into the container will be a bit slower, but overall it
should still be noticibly faster than pre-uv.

Fixes #7245.
@legoktm legoktm requested a review from a team as a code owner December 20, 2024 23:45
@legoktm
Copy link
Member Author

legoktm commented Dec 20, 2024

I tested this PR by creating the dependency part of #7401 using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

move make update-pip-requirements back into development containers
1 participant