Add CI staging job testing Ubuntu 24.04 (noble) #7360
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
changed the title
zenmonkeykstop
force-pushed
the
stg-noble-staging
branch
from
a2ecd5b to
c2e9876
Compare
legoktm
force-pushed
the
stg-noble-staging
branch
from
3aa19e6 to
31c2fcb
Compare
|
Remaining staging failures:
|
legoktm
force-pushed
the
stg-noble-staging
branch
from
31c2fcb to
396e704
Compare
This is an upstream Ubuntu bug that was fixed, but occurs before packages are updated and SecureDrop is installed, so there's really nothing for us to do until new VM images and installer ISOs are made available Fixes #7385.
Instead of maintaining the same version-specific list of profiles six times, just check against a single list of profiles we care about, namely tor and apache2. The rest are not something under our control and vary based on the Ubuntu version. test_apparmor_ensure_not_disabled was mostly broken, because it was looking for files like `/etc/apparmor.d/disabled/usr.sbin./usr/sbin/tor`, which of course would never exist. Instead just check that there are no disable files installed.
legoktm
force-pushed
the
stg-noble-staging
branch
from
396e704 to
90e3527
Compare
* Remove the unnecessary diffing and templating, just keep what we want to assert against as a plain string. * Avoid shelling out to grep, we can do the filtering in Python.
legoktm
force-pushed
the
stg-noble-staging
branch
from
6e19489 to
6aa21e9
Compare
|
I've just been pushing stuff here for now as I work through the failures, later we can figure out if we want them to get individual PRs or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress
Description of Changes
Fixes #7312
Testing
testinfratests.staging(noble)as there are unrelated failures expected there until full noble compatibility