This repository has been archived by the owner on Oct 20, 2018. It is now read-only.
Fix/thanks #78
Merged
Fix/thanks #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes uneeded message code from thanks command
ghost
mentioned this pull request
Closed
| @@ -35,7 +35,8 @@ const thanksCommands = { | |||
|
|
|||
| const namesList = mentions.reduce((userList, mention) => { | |||
| const toUser = mention.screenName.toLowerCase(); | |||
| if (toUser !== fromUser && userList.indexOf(toUser) === -1) { | |||
|
|
|||
| if (toUser !== fromUser && toUser !== 'all' && userList.indexOf(toUser) === -1) { | |||
There was a problem hiding this comment.
@noncentz can you please remove the edit to this line so that this PR can be merged happily ever after?
|
@noncentz can you please put this in the PR message?
|
Replaces capture group with non-capture groups for thanks regexp
Ignore @ bthank user and bthank command
Ignore @ bthank user and bthank command
| ':point_right: *[consider adding a wiki article!]' + wikiUrl + '*'; | ||
| } | ||
| }, | ||
| // messages: { |
There was a problem hiding this comment.
Pending: Test this in bonfire rooms
|
Write a detailed changelog of the changes made in this PR in the PR Message  |
| @@ -106,7 +106,7 @@ const thanksCommands = { | |||
| const username = blob.response.about.username, | |||
| about = blob.response.about, | |||
| uri = 'http://www.freecodecamp.com/' + username; | |||
| str = '> :star: ' + about.browniePoints + ' | @' + username + ' | '; | |||
| str = '> :cookie: ' + about.browniePoints + ' | @' + username + ' | '; | |||
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore thanks in usernames
Ignore tax and tanks triggering thanks command. Fixes #49 or dcsan/gitterbot#142
Removes missing thanks 'message' command
Removes botx command
Replace star emoji with cookie. Fixes #25
Correct typo in readme 'campberbot'
Fix about command. Fixes #86 - 'superstar' status.
Adds love command such as
show me some love camperbotorwe luv you cbothttps://regex101.com/r/pT0zJ1/3