Line continuation indent for triple-strings #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces line continuation based indent for triple strings, which typically span multiple lines without any explicit newlines in the syntax tree (since they are hidden inside the string). This result in the following changes, some of which are clearly bugfixes: Operator chains: ```diff """ abc """ * """ -def -""" + def + """ ``` Operator chain as assignment right hand side: ```diff x = """ -abc -""" * """ -def -""" + abc + """ * """ + def + """ ``` Implicit tuples: ```diff """ abc """, """ -def -""" + def + """ ``` Note that single triple strings as a right hand side is excluded from the indent rule, similar to having `if/try/let/...` blocks as a right hand side.
fredrikekre
force-pushed
the
fe/continue-triple-strings
branch
from
e83bc2f to
90abf5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces line continuation based indent for triple strings,
which typically span multiple lines without any explicit newlines in the
syntax tree (since they are hidden inside the string).
This result in the following changes, some of which are clearly
bugfixes:
Operator chains:
Operator chain as assignment right hand side:
Implicit tuples:
Note that single triple strings as a right hand side is excluded from
the indent rule, similar to having
if/try/let/...blocks as a righthand side.