Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): Add a test for empty file list in git hook. #26

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

Klafyvel
Copy link
Contributor

As it was, the proposed git hook will fail if no Julia file has been edited in the commit (for example if we only edited Project.toml).

As it was, the proposed git hook will fail if no Julia file has been
edited in the commit (for example if we only edited Project.toml).
@fredrikekre
Copy link
Owner

fredrikekre commented Jul 26, 2024

Thanks. I spent some time trying the other week to only run on the staged code too, not sure if there is a better way than

git stash -k
runic ...
# verify result (and stash changes automatically?)
git pop

Do you have any thoughts or ideas here? In particular I don't know if you are allowed to run git commands in a git hook.

README.md Outdated Show resolved Hide resolved
@fredrikekre fredrikekre merged commit 5326088 into fredrikekre:master Jul 26, 2024
14 checks passed
@Klafyvel
Copy link
Contributor Author

Do you have any thoughts or ideas here? In particular I don't know if you are allowed to run git commands in a git hook

I think I remember reading that git hooks are not supposed to apply changes to the files, but I don't remember where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants