-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git-runic script #122
Add git-runic script #122
Conversation
cc @maleadt |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 8 8
Lines 3790 3790
=======================================
Hits 3558 3558
Misses 232 232 ☔ View full report in Codecov by Sentry. |
a10afa2
to
be80940
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Has been working great locally; thanks for adding the necessary features.
Do you automatically run |
I personally do it manually, after staging changes, because I want to be able to choose which formatting changes to accept (I know, going against the philosophy of the tool here). |
Ha, okay. Just out of curiosity -- what formatting don't you like? |
I generally like the formatting, but sometimes I've carefully laid out values for clarify, e.g.:
These become: @@ -56,31 +56,45 @@ end
Base.Tuple(x::Vec4) = tuple(x.a, x.b, x.c, x.d)
for (dispatch_rettyp, julia_rettyp, llvm_rettyp) in
- ((:Signed, :(Vec4{Int32}), :v4u32),
- (:Unsigned, :(Vec4{UInt32}), :v4s32),
- (:AbstractFloat, :(Vec4{Float32}), :v4f32))
+ (
+ (:Signed, :(Vec4{Int32}), :v4u32),
+ (:Unsigned, :(Vec4{UInt32}), :v4s32),
+ (:AbstractFloat, :(Vec4{Float32}), :v4f32),
+ )
@@ -166,9 +184,13 @@ end
h0y = h0(fy)
h1y = h1(fy)
- vals = g0(fy) .* (g0x .* tex(t, px + h0x, py + h0y) .+
- g1x .* tex(t, px + h1x, py + h0y)) .+
- g1(fy) .* (g0x .* tex(t, px + h0x, py + h1y) .+
- g1x .* tex(t, px + h1x, py + h1y))
+ vals = g0(fy) .* (
+ g0x .* tex(t, px + h0x, py + h0y) .+
+ g1x .* tex(t, px + h1x, py + h0y)
+ ) .+
+ g1(fy) .* (
+ g0x .* tex(t, px + h0x, py + h1y) .+
+ g1x .* tex(t, px + h1x, py + h1y)
+ )
return (unpack(T, vals))
end It seems silly to annotate those with |
Adds the
git-runic
script (a modified version ofgit-clang-format
) from #120 (comment) to the repository.