Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent whitespace and newline from being displayed in Code Node #3

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

TRiBotWillB
Copy link

@TRiBotWillB TRiBotWillB commented Jul 14, 2024

This PR should address an issue with the white space and new line that appears in the <pre> code blocks. Picture below displays the current issue.

image

I first attempted a fix by changing the whitespace class in CSS. While it fixes the new line issue, the whitespace for the tabbing is not preserved.

image

@freb97
Copy link
Owner

freb97 commented Jul 14, 2024

Hey @TRiBotWillB! Thanks so much for your contribution! I have tested your change and it looks good to me. I'll append your commit by a bumped version number and adjust the unit tests

@freb97 freb97 merged commit 7d4bdfc into freb97:main Jul 14, 2024
1 of 2 checks passed
@TRiBotWillB
Copy link
Author

@freb97

No problem at all, happy to help. Thanks for creating the library, saved me some time!

I'm happy to update the unit tests if you like. Sorry, rookie mistake on my end! 😄

@freb97
Copy link
Owner

freb97 commented Jul 14, 2024

@TRiBotWillB Don't worry, I've already pushed it! I never really used the code node before since the website i built this package for doesn't need any code snippets, so thanks for noticing! I wouldn't have found it otherwise haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants