Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable platform guessing instead of adding dependencies-prefix #1

Merged

Conversation

radarhere
Copy link

@radarhere radarhere commented Nov 12, 2024

Suggestion for python-pillow#8497

Rather than adding a new setting to setup.py, this just makes use of disable_platform_guessing to not add macOS paths.

I realise that you expect the path supplied to dependencies-prefix to be necessary, but looking at the output of the build, everything looks fine.

@freakboy3742
Copy link
Owner

Yes, the aim was to put dependencies-prefix into the path for linking purposes; but the pyproject.toml configuration of the PATH also achieves that.

There is a slightly ulterior motive because of a requirement on the next piece of work adding iOS support; but given there's already a setting related to this use case, I can go back to the drawing board on that one.

@freakboy3742 freakboy3742 merged commit 0e3eb70 into freakboy3742:homebrew-isolation Nov 13, 2024
@radarhere radarhere deleted the homebrew-isolation branch November 13, 2024 05:48
freakboy3742 pushed a commit that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants