Added phpstan local and github analysis. Some fixes applied

.github/workflows/ci.yml

@@ -30,8 +30,8 @@ jobs:
       if: steps.composer-cache.outputs.cache-hit != 'true'
       run: composer install --prefer-dist --no-progress --no-suggest
 
-    # Add a test script to composer.json, for instance: "test": "vendor/bin/phpunit"
-    # Docs: https://getcomposer.org/doc/articles/scripts.md
-
     - name: Run test suite
       run: composer run-script test
+
+    - name: PHPStan
+      uses: chindit/actions-phpstan@master

composer.json

@@ -4,7 +4,8 @@
     "type": "library",
     "require-dev": {
         "phpunit/phpunit": "^9.2",
-        "mikey179/vfsstream": "^1.6"
+        "mikey179/vfsstream": "^1.6",
+        "phpstan/phpstan": "^0.12.31"
     },
     "license": "MIT",
     "authors": [

phpstan.neon

@@ -0,0 +1,5 @@
+parameters:
+  level: 5
+  paths:
+    - src
+    - tests

src/Reader/Mapper/DtoMapper.php

@@ -5,13 +5,15 @@
 
 class DtoMapper extends RowMapper
 {
+    /** @var string  */
     private $dtoClass;
 
-    public function __construct($dtoClass)
+    public function __construct(string $dtoClass)
     {
         $this->dtoClass = $dtoClass;
     }
 
+    /** @return mixed */
     public function map(array $line, ?array $headers = null)
     {
         $this->assertHeaders($headers);

src/Writer/Writer.php

@@ -4,15 +4,16 @@
 namespace TalkingBit\Csv\Writer;
 
 use TalkingBit\Csv\Shared\CSVFile;
-use TalkingBit\Csv\Shared\CSVSettings;
 use TalkingBit\Csv\Shared\NoTargetFileDefined;
 
 class Writer
 {
     /** @var CSVFile */
     private $targetFile;
+    /** @var bool */
     private $firstRow = true;
 
+    /** @param array<mixed> $row */
     public function writeRow($row): void
     {
         $this->assertCSVFile();
@@ -54,6 +55,9 @@ public function withEnclosure(string $enclosure): self
         return $this;
     }
 
+    /**
+     * @param array<mixed> $row
+     */
     private function writeHeaders(array $row): void
     {
         $headers = array_keys($row);