Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct mtl-2.3 compatibility fix that does not require CPP #54

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Correct mtl-2.3 compatibility fix that does not require CPP #54

merged 3 commits into from
Nov 1, 2024

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Oct 31, 2024

Replacement for #53

@lehins lehins mentioned this pull request Oct 31, 2024
Closed
psibi
psibi reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, Can you also update changelog and bump version ? I will publish a new release.

@lehins
Copy link
Contributor Author

lehins commented Nov 1, 2024

LGTM, Can you also update changelog and bump version ? I will publish a new release.

Most certainly, @psibi. I've also added a minor fix to CI.
I hope life is treating you well. It was good interacting with you, even if briefly 😃

I will publish a new release.

Much appreciated.

@psibi psibi merged commit 624f98f into fpco:master Nov 1, 2024
9 checks passed
@psibi
Copy link
Member

psibi commented Nov 1, 2024

Thanks @lehins! I'm doing well, hope you're doing good too. Always a pleasure interacting with you!

Published a new version: https://hackage.haskell.org/package/weigh-0.0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psibi psibi psibi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @psibi