Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacor: give hybrid cache builder a default metrics registry type #803

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 27, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@MrCroxx MrCroxx added this to the v0.13 milestone Nov 27, 2024
@MrCroxx MrCroxx self-assigned this Nov 27, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) November 27, 2024 07:31
@MrCroxx MrCroxx merged commit 2cac366 into main Nov 27, 2024
21 checks passed
@MrCroxx MrCroxx deleted the xx/default branch November 27, 2024 07:37
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer/src/hybrid/builder.rs 90.10% <ø> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant