Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple foyer instance share the same prometheus #801

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Nov 26, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. See the unit tests for correct usages.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #800

@MrCroxx MrCroxx added bug Something isn't working feature New feature or request labels Nov 26, 2024
@MrCroxx MrCroxx added this to the v0.13 milestone Nov 26, 2024
@MrCroxx MrCroxx self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 97.45763% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-common/src/metrics/registry/prometheus.rs 97.45% 3 Missing ⚠️
Files with missing lines Coverage Δ
foyer-common/src/metrics/registry/prometheus.rs 98.29% <97.45%> (-1.71%) ⬇️

@MrCroxx MrCroxx merged commit 19bc2de into main Nov 26, 2024
24 checks passed
@MrCroxx MrCroxx deleted the xx/multiple-prometheus branch November 26, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: panic while registering metrics with multiple foyer instance
1 participant