chore: remove unused comments and deps, format code

Signed-off-by: MrCroxx <[email protected]>

examples/hybrid_full.rs

@@ -34,7 +34,6 @@ async fn main() -> Result<()> {
         })
         .with_hash_builder(ahash::RandomState::default())
         .with_weighter(|_key, value: &String| value.len())
-        .with_object_pool_capacity(4096)
         .storage(Engine::Mixed(0.1))
         .with_device_options(
             DirectFsDeviceOptions::new(dir.path())

foyer-common/Cargo.toml

@@ -15,7 +15,6 @@ readme = { workspace = true }
 [dependencies]
 bytes = "1"
 cfg-if = "1"
-crossbeam = { workspace = true }
 fastrace = { workspace = true }
 futures = "0.3"
 hashbrown = { workspace = true }

foyer-common/src/event.rs

@@ -34,15 +34,6 @@ pub trait EventListener: Send + Sync + 'static {
     /// Associated value type.
     type Value;
 
-    /// Called when a cache entry is released from the in-memory cache.
-    #[expect(unused_variables)]
-    fn on_memory_release(&self, key: Self::Key, value: Self::Value)
-    where
-        Self::Key: Key,
-        Self::Value: Value,
-    {
-    }
-
     /// Called when a cache entry leaves the in-memory cache with the reason.
     #[expect(unused_variables)]
     fn on_leave(&self, reason: Event, key: &Self::Key, value: &Self::Value)

foyer-memory/Cargo.toml

@@ -19,7 +19,6 @@ cmsketch = "0.2.1"
 equivalent = { workspace = true }
 fastrace = { workspace = true }
 foyer-common = { workspace = true }
-foyer-intrusive = { workspace = true }
 futures = "0.3"
 hashbrown = { workspace = true }
 intrusive-collections = { git = "https://github.com/foyer-rs/intrusive-rs", rev = "94cfac4701dbc0033b7bc27e31c46bf3a12d96d7" }
@@ -42,10 +41,7 @@ zipf = "7.0.1"
 deadlock = ["parking_lot/deadlock_detection"]
 # FIXME: remove sanity feature
 sanity = []
-strict_assertions = [
-    "foyer-common/strict_assertions",
-    "foyer-intrusive/strict_assertions",
-]
+strict_assertions = ["foyer-common/strict_assertions"]
 tracing = ["fastrace/enable", "foyer-common/tracing"]
 
 [[bench]]

foyer-memory/src/cache.rs

@@ -280,8 +280,6 @@ where
     weighter: Arc<dyn Weighter<K, V>>,
 
     event_listener: Option<Arc<dyn EventListener<Key = K, Value = V>>>,
-
-    object_pool_capacity: usize,
 }
 
 impl<K, V> CacheBuilder<K, V, RandomState>
@@ -301,8 +299,6 @@ where
             hash_builder: RandomState::default(),
             weighter: Arc::new(|_, _| 1),
             event_listener: None,
-
-            object_pool_capacity: 4096,
         }
     }
 }
@@ -338,18 +334,6 @@ where
         self
     }
 
-    /// Set object pool capacity.
-    ///
-    /// The object pool is used for avoiding frequent memory allocation.
-    ///
-    /// Each shard gets `object_pool_capacity / shards` slots.
-    ///
-    /// Default: 4096
-    pub fn with_object_pool_capacity(mut self, object_pool_capacity: usize) -> Self {
-        self.object_pool_capacity = object_pool_capacity;
-        self
-    }
-
     /// Set in-memory cache hash builder.
     pub fn with_hash_builder<OS>(self, hash_builder: OS) -> CacheBuilder<K, V, OS>
     where
@@ -363,7 +347,6 @@ where
             hash_builder,
             weighter: self.weighter,
             event_listener: self.event_listener,
-            object_pool_capacity: self.object_pool_capacity,
         }
     }
 
@@ -398,7 +381,6 @@ where
                 hash_builder: self.hash_builder,
                 weighter: self.weighter,
                 event_listener: self.event_listener,
-                // object_pool_capacity: self.object_pool_capacity,
             }))),
             EvictionConfig::S3Fifo(eviction_config) => Cache::S3Fifo(Arc::new(RawCache::new(RawCacheConfig {
                 name: self.name,
@@ -408,7 +390,6 @@ where
                 hash_builder: self.hash_builder,
                 weighter: self.weighter,
                 event_listener: self.event_listener,
-                // object_pool_capacity: self.object_pool_capacity,
             }))),
             EvictionConfig::Lru(eviction_config) => Cache::Lru(Arc::new(RawCache::new(RawCacheConfig {
                 name: self.name,
@@ -418,7 +399,6 @@ where
                 hash_builder: self.hash_builder,
                 weighter: self.weighter,
                 event_listener: self.event_listener,
-                // object_pool_capacity: self.object_pool_capacity,
             }))),
             EvictionConfig::Lfu(eviction_config) => Cache::Lfu(Arc::new(RawCache::new(RawCacheConfig {
                 name: self.name,
@@ -428,7 +408,6 @@ where
                 hash_builder: self.hash_builder,
                 weighter: self.weighter,
                 event_listener: self.event_listener,
-                // object_pool_capacity: self.object_pool_capacity,
             }))),
         }
     }

foyer-memory/src/raw.rs

@@ -115,7 +115,6 @@ where
     pub hash_builder: S,
     pub weighter: Arc<dyn Weighter<E::Key, E::Value>>,
     pub event_listener: Option<Arc<dyn EventListener<Key = E::Key, Value = E::Value>>>,
-    // pub object_pool_capacity: usize,
 }
 
 struct RawCacheShard<E, S, I>
@@ -124,7 +123,6 @@ where
     S: HashBuilder,
     I: Indexer<Eviction = E>,
 {
-    // object_pool: VecDeque<Box<Record<E>>>,
     eviction: E,
     indexer: Sentry<I>,
 
@@ -171,8 +169,6 @@ where
             strict_assert!(!evicted.as_ref().is_in_indexer());
             strict_assert!(!evicted.as_ref().is_in_eviction());
 
-            // FIXME(MrCroxx): remove evicted entry from indexer?
-
             self.usage -= evicted.weight();
 
             garbages.push((Event::Evict, evicted));
@@ -465,13 +461,8 @@ where
 
         let shard_capacity = config.capacity / config.shards;
 
-        // let shard_object_pool_capacity = config.object_pool_capacity / config.shards;
-
         let shards = (0..config.shards)
             .map(|_| RawCacheShard {
-                // object_pool: (0..shard_object_pool_capacity)
-                //     .map(|_| Box::new(Record::empty()))
-                //     .collect(),
                 eviction: E::new(shard_capacity, &config.eviction_config),
                 indexer: Sentry::default(),
                 usage: 0,

foyer/src/hybrid/builder.rs

@@ -159,22 +159,6 @@ where
         }
     }
 
-    /// Set object pool capacity.
-    ///
-    /// The object pool is used for avoiding frequent memory allocation.
-    ///
-    /// Each shard gets `object_pool_capacity / shards` slots.
-    ///
-    /// Default: 4096
-    pub fn with_object_pool_capacity(self, object_pool_capacity: usize) -> Self {
-        let builder = self.builder.with_object_pool_capacity(object_pool_capacity);
-        HybridCacheBuilderPhaseMemory {
-            name: self.name,
-            tracing_options: self.tracing_options,
-            builder,
-        }
-    }
-
     /// Continue to modify the disk cache configurations.
     pub fn storage(self, engine: Engine) -> HybridCacheBuilderPhaseStorage<K, V, S> {
         let memory = self.builder.build();