Handle locked collections/items #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump the Go version to Go 1.23 so we can use range functions.
Bump golangci-lint to handle the new version of Go. Disable
`exportloopref` linter as it is deprecated. Disable the `gci` linter
because it is emitting nonsensical errors and I don't use `gci`.
Ignore one new lint bogus warning.
hermit upgrade go golangci-lint
camh-
force-pushed
the
prompt-and-unlock
branch
3 times, most recently
from
8667acd to
be2bb05
Compare
juliaogris
approved these changes
Sep 3, 2024
|
@juliaogris PTAL if you like. I've addressed all your comments - code reads nicer now, thanks. I've left the individual fixup commits here for now (although I didn't bother to link them to the comments - a bit tedious). It should help see how I made the changes. |
Handle get/store/erase on locked collections and items. When an item is locked, we typically get a "prompt" dbus object that we need to call the "Prompt" method on. This causes the Secret Service (gnome-keyring) to pop up a window prompting the user for the password to unlock the item. Use a Go 1.23 range/iterator function to iterate over the search results when looking up a secret. This handles the unlocked and locked results transparently, unlocking any matching locked items found. The iterator also returns only the items that match the attributes exactly. This makes the implementation of Get and Delete simpler. Bump the "go" version in `go.mod` so that we can use range functions.
camh-
force-pushed
the
prompt-and-unlock
branch
from
67f8424 to
8897c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle get/store/erase on locked collections and items. When an item is
locked, we typically get a "prompt" dbus object that we need to call the
"Prompt" method on. This causes the Secret Service (gnome-keyring) to pop
up a window prompting the user for the password to unlock the item.
Use a Go 1.23 range/iterator function to iterate over the search results
when looking up a secret. This handles the unlocked and locked results
transparently, unlocking any matching locked items found. The iterator also
returns only the items that match the attributes exactly. This makes the
implementation of Get and Delete simpler.
Upgrade the hermit verrsion of Go and bump the "go" version in
go.modso that we can use range functions.