Add first cut of git-credential-fdoss #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaogris
approved these changes
Aug 8, 2024
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Explain why binary is called what it is. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Explain what SecretService implements and why a bit better. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Explain what SecretService implements and why a bit better. Also fix the link to the spec as that changed just after I made the link. It was stable for YEARS before that! Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Expand note on the `Secret` struct that is marshalable by the dbus library. Update the link to the spec which just changed. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Use shorter sentences explaining NewSecretSecvice. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Make the description of NewSecretService clearer by linking to the spec on "sessions" and qualifying the word "session" in the error case. Fix typo. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Fix poor grammar: "name/value arbitrary strings" -> "arbitrary name/value strings" Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Reword Get() so that items and collections make a bit more sense and link to them in the spec. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Add example of git-credential protocol. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Make the anonymous inline function in Marshal much shorter (simpler). Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Add usage message to main.go with make target to update it. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Spelling fix: s/amd/and/g Addresses: #3 (comment) Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Describe origins of label. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Simplify description of makeAttrs. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Link to git-credential-libsecret attribute mapping. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Rename: s/makeSecretVal/formatSecretVal/ Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Simplify wording of formatSecretVal doc string. Add link to secret encoding in git-credential-libsecret. Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Simplify wording: s/so as to be/to be/ Addresses: #3 (comment)
camh-
added a commit
that referenced
this pull request
Aug 27, 2024
Reword issue with secret encoding and gnome-keyring's unencrypted keyrings. Addresses: #3 (comment)
juliaogris
reviewed
Aug 28, 2024
|
still lgtm |
Add the initial version of `git-credential-fdoss`. It basically works but has some unsupported cases such as: * Handling "prompts" * Handling locked secrets (probably requires prompts to work) * Using a non-default keyring * Creating a non-existent default keyring (not even sure we we should, but this is something libsecret does, and hence git-credential-libsecret too) * Encrypted sessions via dbus (not "plain") * Non-pageable memory for holding secrets Also missing: * Go unit tests * Expanded readme with setup instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the initial version of
git-credential-fdoss. It basically worksbut has some unsupported cases such as:
but this is something libsecret does, and hence
git-credential-libsecret too)
Also missing:
Note: This is an updated version of PR #2, which was automatically
closed when the base branch was deleted.