Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and clean up the RAID code and code using the RAID code #40

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Jul 29, 2024

No description provided.

@pyrco pyrco requested a review from Schamper July 29, 2024 14:37
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 92.18750% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (de2aefd) to head (3db7119).

Files Patch % Lines
dissect/volume/md/md.py 88.88% 3 Missing ⚠️
dissect/volume/ddf/ddf.py 91.66% 1 Missing ⚠️
dissect/volume/raid/stream.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   72.42%   72.29%   -0.14%     
==========================================
  Files          26       26              
  Lines        1962     1960       -2     
==========================================
- Hits         1421     1417       -4     
- Misses        541      543       +2     
Flag Coverage Δ
unittests 72.29% <92.18%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dissect/volume/ddf/ddf.py Outdated Show resolved Hide resolved
dissect/volume/md/md.py Outdated Show resolved Hide resolved
dissect/volume/md/md.py Outdated Show resolved Hide resolved
dissect/volume/raid/raid.py Show resolved Hide resolved
@pyrco pyrco requested a review from Schamper July 30, 2024 07:54
@pyrco pyrco merged commit 18f600f into main Aug 1, 2024
17 of 18 checks passed
@pyrco pyrco deleted the refactor-raid-code branch August 1, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants