Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removes unnecessary token from setup instructions #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nJim
Copy link

@nJim nJim commented May 4, 2022

Work includes:

  • Removes an unnecessary token from README instructions to simplify setup. This token is important to build and modify packages but is not needed to download public packages.

Testing:

  • Create a new project and verify that this package can be installed without the token.
mkdir someproject && cd $_
npm init -y
echo "@fourkitchens:registry=https://npm.pkg.github.com" > .npmrc
npm install --save-dev @fourkitchens/eslint-config-and-other-formatting

@nJim nJim self-assigned this May 4, 2022
@ModulesUnraveled
Copy link
Contributor

Oh! I thought this was required for some reason... I'll test it out

@nJim nJim requested a review from ModulesUnraveled May 4, 2022 21:43
@ModulesUnraveled
Copy link
Contributor

@nJim When I remove that line on a project I've set up to use this, I get the following error:

npm install

npm ERR! code E401
npm ERR! Incorrect or missing password.
npm ERR! If you were trying to login, change your password, create an
npm ERR! authentication token or enable two-factor authentication then
npm ERR! that means you likely typed your password in incorrectly.
npm ERR! Please try again, or recover your password at:
npm ERR!     https://www.npmjs.com/forgot
npm ERR!
npm ERR! If you were doing some other operation then your saved credentials are
npm ERR! probably out of date. To correct this please try logging in again with:
npm ERR!     npm login

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/brian/.npm/_logs/2022-05-04T22_15_29_730Z-debug.log

When I add it back in, and run npm install agin, everything installs successfully... Maybe there's another way to authenticate your machine with GitHub that doesn't require this token to be passed at this point?

@ModulesUnraveled
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants