-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an organizer customer account and fee system | Task management #452
base: development
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR implements a task management system using django-celery-beat to handle scheduled tasks, particularly focusing on billing-related operations. The implementation moves task scheduling from static settings to a database-backed system and adds an admin interface for managing these tasks. Class diagram for Task Management SystemclassDiagram
class TaskList {
+template_name
+context_object_name
+model
+filter_form()
+get_queryset()
+process_task_data(task)
+get_context_data(**kwargs)
+post(request, *args, **kwargs)
}
class TaskFilterForm {
+name
+status
+filter_qs(qs)
}
class PeriodicTask {
+name
+task
+crontab
}
class CrontabSchedule {
+day_of_month
+hour
+minute
}
TaskList --> TaskFilterForm
TaskList --> PeriodicTask
PeriodicTask --> CrontabSchedule
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider scoping the use of scopes_disabled() more narrowly to just the specific database queries that need it, rather than wrapping entire functions. The current broad usage could impact performance at scale.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR is part of issue #383
Apply django-celery-beat to manage tasks, this PR implement:
Summary by Sourcery
Implement a task management system for administrators and refactor billing tasks to use 'django-celery-beat' for better task scheduling and management.
New Features:
Enhancements:
Build: