Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed controlled Date and TimePicker value update #198

Merged
merged 2 commits into from
Jul 19, 2017
Merged

Fixed controlled Date and TimePicker value update #198

merged 2 commits into from
Jul 19, 2017

Conversation

ferencrocks
Copy link
Contributor

Possible fix for issue #180

@ryanblakeley
Copy link
Collaborator

@ferencrocks Hey can you squash those commits please?

@mbrookes
Copy link
Collaborator

@rojobuffalo Thanks for picking up the open issues and PRs! That reminded me to ask - would you like me to transfer the repo to you, or create its own org? Seems a little unfair that it still appears to be mine when you're doing all the work these days.

On this one, there's now the option to squash and merge (drop-down icon on merge button), so you don't have to wait for @ferencrocks to do it.

@ryanblakeley
Copy link
Collaborator

Cool, thanks for pointing out that feature. I'm ok with you transferring the repo but I don't mind either way.

@ryanblakeley ryanblakeley merged commit f7b4c32 into formsy:master Jul 19, 2017
@mbrookes
Copy link
Collaborator

I'm happy for you to take it. I tried transferring it, but I think you'll need to delete your fork first, so let me know when that's done, and I'll give it another go.

@ryanblakeley
Copy link
Collaborator

Ok. I just renamed my fork.

@mbrookes
Copy link
Collaborator

Now I get a different error 🤦‍♂️
"rojobuffalo already has a repository in the mbrookes/formsy-material-ui network"

Looks like you'll have to delete your fork, sorry.

@ryanblakeley
Copy link
Collaborator

Ok, I deleted it.

@mbrookes
Copy link
Collaborator

"You have the bridge."

@ryanblakeley
Copy link
Collaborator

Captain

@ryanblakeley
Copy link
Collaborator

Thanks @mbrookes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants